search

neuland-ingolstadt / neuland.app

A free & open source, web-based replacement for the official app of the Technische Hochschule Ingolstadt built with React and Next.js.
https://neuland.app
GNU Affero General Public License v3.0
36 stars 31 forks source link

Migrates Neuland API and adds Neuburg canteen #402

Closed Robert27 closed 1 month ago

Robert27 commented 4 months ago
alexhorn commented 4 months ago

Honestly I'm still not convinced this is a good idea. The barrier of entry for a new developer is high enough as it is, it we migrate to GraphQL we would move the bar even higher. I'm afraid this will make it even harder to motivate new people to join the development team.

Robert27 commented 4 months ago

@alexhorn Simplifying, shortening and splitting the code, as I have done in this PR, is in my opinion the best way to lower the barrier to entry. Also, the old API was not documented or typed at all, on the contrary the new API is highly user friendly with interactive query dashboard and documentation. The extra repository also makes it clearer and easier to maintain.

I also find it a bit dubious to claim that it would put people off, in the past the API has never been touched by anyone new. The reasons might be that it was never necessary or the lack of documentation put everyone off. Moreover, nothing about GraphQL is complicated, it is just a little different to query, but does not require a high level of knowledge.

In my opinion personal ego and pride should be put aside and instead open the way for the future, especially as the new API is build on top of the old one and only improves it, no work is lost.

Robert27 commented 4 months ago

Thanks for your review. However, I would still wait until a person with server access, like @alexhorn, also deployed the develop branch of the backend server and then add a new env var with the development backend URL. Then we would have the same distinction as with the neuland.app and would later expose our main app branch less to the potential problems of the quick development changes of the backend server.

alexhorn commented 4 months ago

Since I am being personally attacked after offering my opinion, I'm will not be reviewing this PR. I would recommend waiting for the approval of @M4GNV5.

BuildmodeOne commented 3 months ago

With all personal stuff asides, how do we move forward with this PR?