search

neumatho / NostalgicPlayer

Music/module player written in C# that can play old modules from the Amiga and PC days. You can download modules from my home page.
https://nostalgicplayer.dk
MIT License
36 stars 4 forks source link

Third-party license notices missing OpenMPT #88

Closed sagamusix closed 3 weeks ago

sagamusix commented 3 weeks ago

I generally don't care if people copy over a couple lines of code and use my module loaders as a reference / documentation source for their own loaders and then don't do any attribution, but the recently-added MO3 decoder is clearly a 1:1 copy of pretty much the entire MO3 loader from OpenMPT. It would be nice if you could add a reference here: https://github.com/neumatho/NostalgicPlayer?tab=readme-ov-file#license Thanks.

neumatho commented 3 weeks ago

Yes, you're right that parts of my MO3 converter are copied from OpenMPT, specially the decruncher and some parts of the loaders. The savers are written by me. I have credited you, which can be shown in the player as you can see here (around line 150):

https://github.com/neumatho/NostalgicPlayer/blob/main/Source/Agents/ModuleConverters/Mo3Converter/Resources.resx

However, I don't have any problems adding a license, so I have done that too.

sagamusix commented 3 weeks ago

Thanks!