neume-network / core

A socially-scalable music NFT indexer.
https://neume.network
GNU General Public License v3.0
26 stars 11 forks source link

build: remove default `RPC_HTTP_HOST` #61

Closed almndbtr closed 2 years ago

almndbtr commented 2 years ago

Summary

Closes https://github.com/neume-network/core/issues/60

This changes two parts of the example .env-copy file:

As a result, on a fresh clone, if the developer runs this app as-is, it will throw an error notifying the developer that it's not set.

This "nudges" developers to replace this (and all relevant values) to their preference.

For review

👋 @TimDaub - Hi! Thanks for letting me contribute. This is a first pass of what I had in mind to incrementally improve my own developer experience. I'm happy to hear any changes I should make before getting this merged in. Thanks again for all of your help!

almndbtr commented 2 years ago

Thanks so much! 🙌🏾