`function transform` isn't redirecting new messages to the worker

neume-network / strategies

Indexing strategies for the neume network.

GNU General Public License v3.0

11 stars 7 forks source link

`function transform` isn't redirecting new messages to the worker #214

Closed TimDaub closed 2 years ago

TimDaub commented 2 years ago

See this function: https://github.com/neume-network/strategies/blob/54ca4226b8346dc4ede14042427c1c8826a72950/src/lifecycle.mjs#L82
In lineReader a buffer is created that tracks all messages emitted by a transformer: https://github.com/neume-network/strategies/blob/54ca4226b8346dc4ede14042427c1c8826a72950/src/lifecycle.mjs#L34
And then this buffer is returned to function transform. But it never forwards those messages to the worker

il3ven commented 2 years ago

We can also look into changing the transform interface as to not return any messages. Earlier we were using it to start new strategies but currently they don't serve any purpose.

TimDaub commented 2 years ago

you are right it sounds like an elegant solution this problem.