neume-network / strategies

Indexing strategies for the neume network.
GNU General Public License v3.0
11 stars 7 forks source link

merging results of two different strategies is painful and all past workarounds have lead to bad code structure #236

Open TimDaub opened 2 years ago

TimDaub commented 2 years ago
TimDaub commented 2 years ago

/cc @sirnicolaz for visibility

TimDaub commented 2 years ago

In addition: music-os-accumulator is strictly dependent on the existence of e.g. a previous strategies files. So e.g. if we invoked call-block-logs with a block range that doesn't include a zora NFT mint, it means that music-os-accumulator probably fails as it won't find any prior files related to the zora crawl, e.g. zora-get-tokenuri.

With the more frequent block-logs crawl that may not contain any NFT mints for a run (e.g. when we run every ten minutes), we must consider this and appropriately log/error.

Here are two commits that already lessen this problematic:

/cc @il3ven for visibility too.