search

neume-network / strategies

Indexing strategies for the neume network.
GNU General Public License v3.0
11 stars 7 forks source link

everywhere use integer for block number as opposed to string #283

Closed il3ven closed 1 year ago

il3ven commented 1 year ago

This PR fixes #270 by using integer for block number. There were two methods to solve this issue. One was to modify music-os-accumulator and typecast string to integer. The other was to tackle the problem at its root and use integer from the starting. This PR chose the latter approach as to maintain consistency and not typecast to-and-fro.

A question I have is how will we modify the existing data in neume-network/data? Should we re-run the whole crawler from start in an Ethereum node?

TimDaub commented 1 year ago

A question I have is how will we modify the existing data in neume-network/data? Should we re-run the whole crawler from start in an Ethereum node?

yeah can do that. It's a bit annoying but that is the current manual process. But I agree that automating this would be nice.