Closed Kunkka0822 closed 1 year ago
The PR looks good to me. I will fix the github actions issue, run the tests and then merge the PR.
It looks like the checks failed because the github action expects the branch to exist in this repo instead of @Kunkka0822's fork.
https://github.com/neume-network/strategies/actions/runs/3107105334/jobs/5035690711#step:2:455
How can I fix this problem?
It looks like the checks failed because the github action expects the branch to exist in this repo instead of @Kunkka0822's fork.
https://github.com/neume-network/strategies/actions/runs/3107105334/jobs/5035690711#step:2:455
I fixed it in https://github.com/neume-network/strategies/commit/450f646b4e7661d9e82690704ce5a1d9d1830b48.
@TimDaub The unit tests GitHub actions are not able to run because PRs don't have access to secrets. I couldn't find any solution for this. There are only hacks like ok-to-test. We can either manually test external contributions or remove secrets and use a public RPC node like https://rpc.ankr.com/eth.
That said, I have manually tested this PR and merging it now. Thanks @Kunkka0822.
It looks like the checks failed because the github action expects the branch to exist in this repo instead of @Kunkka0822's fork.
https://github.com/neume-network/strategies/actions/runs/3107105334/jobs/5035690711#step:2:455