search

neume-network / strategies

Indexing strategies for the neume network.
GNU General Public License v3.0
11 stars 7 forks source link

when external contributors send PRs then the secrets aren't used in CI and hence tests fail #290

Open TimDaub opened 1 year ago

TimDaub commented 1 year ago

Original post from @il3ven in https://github.com/neume-network/strategies/pull/287

    > It looks like the checks failed because the github action expects the branch to exist in this repo instead of @Kunkka0822's fork.

https://github.com/neume-network/strategies/actions/runs/3107105334/jobs/5035690711#step:2:455

I fixed it in https://github.com/neume-network/strategies/commit/450f646b4e7661d9e82690704ce5a1d9d1830b48.

@TimDaub The unit tests GitHub actions are not able to run because PRs don't have access to secrets. I couldn't find any solution for this. There are only hacks like ok-to-test. We can either manually test external contributions or remove secrets and use a public RPC node like https://rpc.ankr.com/eth.

That said, I have manually tested this PR and merging it now. Thanks @Kunkka0822.

Originally posted by @il3ven in https://github.com/neume-network/strategies/issues/287#issuecomment-1258475167