search

neume-network / strategies

Indexing strategies for the neume network.
GNU General Public License v3.0
11 stars 7 forks source link

add zora drops strategies #303

Closed neatonk closed 2 years ago

neatonk commented 2 years ago

See #256

TimDaub commented 2 years ago

Overall looks very good and mergable. Just one minor thing is that I spontaneously changed the strategy transformer interface and so now messages isn't a required property anymore, check it here: https://github.com/neume-network/strategies/commit/5b087b54660abba2a4c3570db5805c847c3700bb

neatonk commented 2 years ago

Overall looks very good and mergable. Just one minor thing is that I spontaneously changed the strategy transformer interface and so now messages isn't a required property anymore, check it here: 5b087b5

I've fixed the transformer interface. Might as well merge this when ready so it doesn't fall out of sync with the main branch. The missing zora-drops-get-tokenuri strategy can be added in another PR.

TimDaub commented 2 years ago

ok I ran all tests locally and this seems to work