neume-network / strategies

Indexing strategies for the neume network.
GNU General Public License v3.0
11 stars 7 forks source link

Implement call-soundeditionv1-tokenuri extractor and transformer #311

Closed Kunkka0822 closed 1 year ago

Kunkka0822 commented 1 year ago
il3ven commented 1 year ago

From what I understood in the #294 discussion. We should track all tokenIDs and not only tokenID=1. From the tokenURI we can get trackNumber. It will let us filter all the unique songs. If two tokenIDs have the same trackNumber then they are the same song.

Please correct me if I am wrong.

TimDaub commented 1 year ago

From what I understood in the #294 discussion. We should track all tokenIDs and not only tokenID=1. From the tokenURI we can get trackNumber. It will let us filter all the unique songs. If two tokenIDs have the same trackNumber then they are the same song.

Please correct me if I am wrong.

yes all tokenURIs

Kunkka0822 commented 1 year ago

From what I understood in the #294 discussion. We should track all tokenIDs and not only tokenID=1. From the tokenURI we can get trackNumber. It will let us filter all the unique songs. If two tokenIDs have the same trackNumber then they are the same song. Please correct me if I am wrong.

yes all tokenURIs

Okay, I got it. I will work on this issue.

TimDaub commented 1 year ago

@Kunkka0822 is there a reason why this is a pinned issue?

TimDaub commented 1 year ago
  • We need a call-soundeditionv1-tokenuri strategy to get the tokenUri. The result is something like ar://zUTuV0VL7w1z5cuGkBs2b-O3DRY2O2qA_ifSQqjLnzA/1.

this is now done.

TimDaub commented 1 year ago

@Kunkka0822 the next step is taking all the called tokenURIs (which are Arweave links) and then sending type: arweave messages to the extraction-worker to download all the JSON objects.

Kunkka0822 commented 1 year ago

@TimDaub Okay, I got it. So the next step will be sound-protocol-get-tokenuri. May I implement feature to filter unique songs by tracknumber in this part or not?

TimDaub commented 1 year ago

We definitely want that at some point but I'd leave it to your disgression where you think it fits best to implement it

Kunkka0822 commented 1 year ago

@TimDaub I think this issue is already solved.