use only native IPFS URLs - Githubissues

neume-network / strategies

Indexing strategies for the neume network.

GNU General Public License v3.0

11 stars 7 forks source link

use only native IPFS URLs #312

Closed il3ven closed 1 year ago

il3ven commented 1 year ago

This PR's purpose is to refactor strategies so that they only use ipfs:// URLs.

Changes:

Introduce anyIpfstoNative function which takes any URL such as QmSJ3waSjiqLLgrW3n6dXUJhmRaouUYsBdf1kGs1duC9St.ipfs.dweb.link or ipfs.io/ipfs/QmSJ3waSjiqLLgrW3n6dXUJhmRaouUYsBdf1kGs1duC9St and converts it into native IPFS URL such as ipfs://QmSJ3waSjiqLLgrW3n6dXUJhmRaouUYsBdf1kGs1duC9St
Introduce ifIpfsConvertToNativeIpfs function which will convert given URL to native IPFS if it is a valid IPFS URL. We need this to convert soundxyz's audio_url.
Remove logic to convert native IPFS to IPFS gateway from get-ipfs-tokenuri factory. (e75e3af1aa9fd825915c80d46e8bcc61bf1ae660 and 42802b359cf18cb87961c6f05d628f787238622e)

TODO

[ ] Add tests for ifIpfsConvertToNativeIpfs function

Note

To test this PR we need to update extraction-worker in core. I did it locally and this branch worked. I will raise a PR for it in core.

TimDaub commented 1 year ago

Nice, I like it. Another thing I'd do is to make one function that is specifically capable of matching an IPFS CID in all those input strings you're testing with and then making the native ipfs formatting another function where the return is ipfs://${hash}, as I think people generally find it valuable to extract IPFS CIDs from any sort of strings.

And yeah as I said before, I think this would make a great npm package!

TimDaub commented 1 year ago

This PR also fixes: https://github.com/neume-network/strategies/issues/293

TimDaub commented 1 year ago

To test this PR we need to update extraction-worker in core. I did it locally and this branch worked. I will raise a PR for it in core.

OK

TimDaub commented 1 year ago

So for me this PR looks good to merge but it's still in DRAFT mode so I didn't want to do it myself. But @il3ven you have my go.

il3ven commented 1 year ago

@TimDaub Thank you for add IPFS_HTTP_GATEWAY_KEY to ipfs msg factory. I just need to check if anything is missing and then I will merge.

TimDaub commented 1 year ago

@TimDaub Thank you for add IPFS_HTTP_GATEWAY_KEY to ipfs msg factory. I just need to check if anything is missing and then I will merge.

ok I'll leave this to you