neume-network / strategies

Indexing strategies for the neume network.
GNU General Public License v3.0
11 stars 7 forks source link

implement a strategy for each song that finds the artist address #324

Open TimDaub opened 2 years ago

TimDaub commented 2 years ago
neatonk commented 2 years ago

For zora drops contracts the creator address could be used.

https://github.com/neatonk/strategies/blob/021e33808b29fa15ca9961d0a3e6fc6a06f63689/src/strategies/zora-drops-filter-contracts/transformer.mjs#L27-L31

TimDaub commented 2 years ago

Here's what @reimertz wants:

minter whoever minted the nft artist artist who created the song / track owner who is the current owner of said nft

TimDaub commented 2 years ago
TimDaub commented 2 years ago

For Zora (catalog v1), the transaction sender of the mint transaction is likely the artist.

TimDaub commented 2 years ago

For zora artworks usually the minter is the artist unless there are contracts interacting with the zora contract. So actually we should examine catalog v1 specifically.

TimDaub commented 2 years ago
TimDaub commented 2 years ago

we're now requiring an artist.address property in /schema: https://github.com/neume-network/schema/commit/db192d2fa1a88c84a00f2a074646b94e0f519038

TimDaub commented 2 years ago

For Zora (catalog v1), the transaction sender of the mint transaction is likely the artist.

this was confirmed to me by a catalog contributor