search

neume-network / strategies

Indexing strategies for the neume network.
GNU General Public License v3.0
11 stars 7 forks source link

Sound Protocol use `artist` instead of `artist_name` #343

Closed reimertz closed 1 year ago

reimertz commented 1 year ago

It seems Sound Protocol updated the metadata spec to use artist instead of artist_name

reimertz commented 1 year ago

Hi there @Kunkka0822 / @TimDaub. This PR should fix the missing Artist name for the new Sound Protocol property.

Another test is the reason checks fail. 

✔ strategies › sound-protocol-get-tokenuri › transformer_test › sound-protocol-get-tokenuri transformer
TimDaub commented 1 year ago

Hi there @Kunkka0822 / @TimDaub. This PR should fix the missing Artist name for the new Sound Protocol property.

Another test is the reason checks fail.

✔ strategies › sound-protocol-get-tokenuri › transformer_test › sound-protocol-get-tokenuri transformer

ok it could be CI being flaky, I will get this merged and integrated asap.

TimDaub commented 1 year ago

Another test is the reason checks fail.

yes, locally everything works, it's this issue: