neumino / chateau

Another (awesome) data explorer for RethinkDB
207 stars 38 forks source link

.gitignore config.js? #19

Closed eiriksm closed 11 years ago

eiriksm commented 11 years ago

Just a suggestion, but I personally prefer to have this kind of file in .gitignore

Instead we could have a config-template, and add an extra step in the installation guide.

This way I don't have to see my config changes as diff in git, and - more important - I don't accidentally commit some kind of sensitive data (or override with some crazy new defaults).

Let me know what you think, and I'll submit a pull request for it if you want!

And again: Awesome work!

neumino commented 11 years ago

Yes, I totally agree!

The current config.js should be rename config.sample.js and we should have config.js in the gitignore