neumino / chateau

Another (awesome) data explorer for RethinkDB
207 stars 38 forks source link

jade is now pug #68

Open Extarys opened 7 years ago

Extarys commented 7 years ago

Just to let you know jade is now known as pug. Should change dep and test.

kevintechie commented 7 years ago

chateau won't install now.

Extarys commented 7 years ago

I want my phpmyadmin for rethinkDB please :P

neumino commented 7 years ago

Hum, I just tried, and this doesn't prevent chateau from being installed - There's just a warning during the installation

Extarys commented 7 years ago

Thanks then will install (didn't try once I saw the dep with jade)

kevintechie commented 7 years ago

Definitely won't install for me. I'm installing globally over the previous version using NPM 5.0.4.

I get the following error:

npm ERR! code ETARGET
npm ERR! notarget No matching version found for jade@= 1.0.2
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.
npm ERR! notarget 
npm ERR! notarget It was specified as a dependency of 'chateau'
npm ERR! notarget 
Extarys commented 7 years ago

@neumino Is it possible you already had the Jade dep installed on your machine?

neumino commented 7 years ago

This works on my machine after cleaning up already installed packages: npm install jade@1.0.2

For what it's worth (and what I remember), switching to pug is not a no-op, so there's a bit of work needed.

Extarys commented 7 years ago

I created a pull request to switch from Jade to Pug - Wasn't able to fix the Add field in tables though. @kevintechie If you have time, you can try this.

sukrosono commented 7 years ago

i think it just good practice to keep dependency up to date, now i am about to listing the outdated warning when we install chateau :