neumino / chateau

Another (awesome) data explorer for RethinkDB
207 stars 38 forks source link

Quick fix from Jade to Pug #69

Open Extarys opened 7 years ago

Extarys commented 7 years ago

Tested and working.

The only thing that didn't work is the "Add field" in a table for an unknown reason. Field doesn't get created or Express put a console error with an undefined value.

Everything else works.

Extarys commented 7 years ago

Added .btn-primary or .btn-delete classes on primary action buttons for better UX.

sukrosono commented 7 years ago

Awesome, but why it's add rethinkdb as dependency?

Extarys commented 7 years ago

It jumps from "rethinkdb": ">= 1.12.0-0" to "rethinkdb": "^2.3.3". it's a huge jump but it was already a dependency though since it needs a driver to connect and manage your database stuff. It's like, you need mysql driver for phpmyadmin. :P

See file package.json for dependency changes.

Note that it was very quickly tested and I cannot guarantee anything. Feel free to download and play around. Also, I'm not a pull/push professional, some mistake may have been make. (Never really used git before 2017 and I mostly comment)

Note that I did a couple of small typo changes a second ago directly in this. (Bump to 0.4 too since we change engine)

sukrosono commented 7 years ago

@Extarys ok i got it if it was previously there, and with your explanation. You are awesome, i also still new to git. I am still unable to install chateau on my machine :disappointed: . It throw Node.js EACCES after i change the chateau config.

Extarys commented 7 years ago

THANKS :D I needed this - too much saltiness yesterday on github. I had similar issue (under linux) npm had access issue maybe npm permissions fix will help (make sure this is your issue first) . If you every need help or just chat, ping me, I need friends :P

sukrosono commented 7 years ago

yay i need friends too, maybe we can chat at gitter sometime. I got error EACCES on using port, i guest the express port. i am gona leave it for now.

Extarys commented 7 years ago

Oh you can just search i the files and change it for like 3010. It might be another nodejs app.