neumino / reqlite

Reqlite - RethinkDB in JavaScript
MIT License
338 stars 25 forks source link

replace request with superagent #53

Closed threepointone closed 8 years ago

threepointone commented 8 years ago

This PR is to replace usage of request with superagent - https://github.com/visionmedia/superagent. This is built for so-called 'isomorphic' stack; specifically it's much lighter by weight on the browser, and doesn't bundle along a number of node-specific bits. I've used this at scale in many big projects, and it works well.

neumino commented 8 years ago

Why do you need superagent? Why not just going straight to Server with your query? Or are you trying to do something else?

threepointone commented 8 years ago

This is for r.http, not the client.

neumino commented 8 years ago

browserify takes care of that now :)

Thanks @threepointone for all your help!