search

neumino / reqlite

Reqlite - RethinkDB in JavaScript
MIT License
338 stars 25 forks source link

Add way to stop server programmatically #66

Closed yamalight closed 8 years ago

yamalight commented 8 years ago

Here's a PR for #65 I'd add unit tests too, but there seem to be no tests for lifecycle (if I missed it - please let me know, I'll add them ASAP)

yamalight commented 8 years ago

Addressed all the points. Please, have a look.

yamalight commented 8 years ago

updated - I'd assigned IDs directly to connections (since otherwise there's no way to get them from callback later, or I'm missing something). please have a look.

neumino commented 8 years ago

Just two more little things, and then we are good to merge I think. @yamalight -- Thanks for the pull request and for your patience!

yamalight commented 8 years ago

@neumino thanks for your patience as well, not just anyone can keep explaining things like this :smile:

neumino commented 8 years ago

Awesome, looks good. Thanks a lot @yamalight :)

yamalight commented 8 years ago

@neumino sweet, thanks for quick merge!