neumino / rethinkdbdash

An advanced Node.js driver for RethinkDB with a connection pool, support for streams etc.
MIT License
848 stars 109 forks source link

Fix pool matching when a server has no assigned pool #354

Open aleclarson opened 6 years ago

aleclarson commented 6 years ago

There was a missing for-loop that caused a ReferenceError to be thrown.

aleclarson commented 6 years ago

@neumino This PR should be merged ASAP.

It fixes a ReferenceError in PoolMaster.prototype.fetchServers (specifically this line where k is never defined).

aleclarson commented 6 years ago

When I get the chance, I'll add a test that breaks without this commit.

thelinuxlich commented 6 years ago

merged in https://github.com/RebirthDB/rebirthdb-js