neumino / rethinkdbdash

An advanced Node.js driver for RethinkDB with a connection pool, support for streams etc.
MIT License
848 stars 109 forks source link

New timeFormat parameter: "ISO8601" #377

Open thelinuxlich opened 6 years ago

thelinuxlich commented 6 years ago

This solves the issue #376 and is a desired feature in RethinkDB: https://github.com/rethinkdb/rethinkdb/issues/5061

I had to add luxon as a dependency for this one, but I think it is doable.

thelinuxlich commented 6 years ago

Also https://github.com/rethinkdb/rethinkdb/issues/3027

thelinuxlich commented 6 years ago

All tests passed but it failed due to timeout? wtf

atris commented 6 years ago

LGTM. Can you retrigger the tests to do a successful run?

thelinuxlich commented 6 years ago

merged in https://github.com/RebirthDB/rebirthdb-js