search

neumino / rethinkdbdash

An advanced Node.js driver for RethinkDB with a connection pool, support for streams etc.
MIT License
848 stars 108 forks source link

Bundle TypeScript typings with this package #386

Open davidfarinha opened 6 years ago

davidfarinha commented 6 years ago

It's recommended to store the TypeScript typings with the npm package and it helps TypeScript developers have access to the type definitions immediately in the same package instead of having to depend on a separate @types/xxx package.

I am working on some typings (a single index.d.ts file) for this module which extend the @types/rethinkdb typings in DefinitelyTyped. When they're tested I'd be happy to pull them into this package (which would be the preferred way) instead of pulling them into the DefinitelyTyped repository.

ChrisTalman commented 6 years ago

That'd be really useful.

I'd be happy to help out where I can, although sadly my knowledge of type definitions is limited.

bbar commented 6 years ago

https://github.com/rethinkdb/rethinkdb-ts