search

neumino / rethinkdbdash

An advanced Node.js driver for RethinkDB with a connection pool, support for streams etc.
MIT License
848 stars 109 forks source link

Fix: options.family parameter to match node:net specification #400

Open telno opened 2 years ago

telno commented 2 years ago

Per node documentation, family parameter should be numeric 0 (any), 4 (ipv4), or 6 (ipv6)

https://nodejs.org/docs/latest-v18.x/api/net.html#socketconnectoptions-connectlistener

Unknown why this didn't result in runtime error until node v18, but fails on recent build with string values 'ipv4' or 'ipv6'