search

neumino / thinky

JavaScript ORM for RethinkDB
http://justonepixel.com/thinky/
Other
1.12k stars 128 forks source link

Add pingInterval option to config #554

Closed balintant closed 8 years ago

balintant commented 8 years ago

The server is closing connection after a time, which makes our staging environment unavailable. We don't want to restart the server several times because of this issue (by exiting with non-zero error code), but I found the solution on the official rethinkdbdash.

The connection was closed by the other party.

When importing the driver, I can set

https://github.com/neumino/rethinkdbdash

It was implemented following this discussion, which describes the issue pretty well: https://github.com/neumino/rethinkdbdash/issues/192#issuecomment-212753388

Can we add this option to the config, so it will ping the server every x seconds and avoid the connections getting closed?

balintant commented 8 years ago

Just found out that config is passed to rethinkdbdash directly, which means no need for this change.

This should be mentioned in the documentation in my opinion.

Glathrop commented 6 years ago

@balintant this is old.... but you're saying thinky configuration is passed directly to rethinkdbdash?

Future googlers.... the answer is yes. You simply pass rethinkdbdash config options from thinky.