search

neunato / homm3-unpacker

Parse HOMM3 game files
https://neunato.github.io/homm3-unpacker/
MIT License
33 stars 5 forks source link

Missing selection of creature sprites #4

Closed ChristopherRotter closed 2 years ago

ChristopherRotter commented 2 years ago

In rare cases, the selection frames of creatures are not exported as expected. For instance, this happens with Beholder (cbehol.def) on frame cbehol31.pcx.

The reason is that the frame is first exported as part of the group "moving", for which selection is ignored, but the same frame is also part of the group "standing", which is processed after "moving" and thus the pcx unpacking is not triggered again and the selection is not exported.

This PR should fix any edge case where a frame should have a selection but was already unpacked as part of a non-selection group.

neunato commented 2 years ago

Great catch! I'm on vacation until next week, will have a more detailed look once I return home.

neunato commented 2 years ago

Thank you for the contribution!