neuoy / KSPTrajectories

A Kerbal Space Program mod to display trajectory predictions, accounting for atmospheric drag, lift, etc.
GNU General Public License v3.0
144 stars 47 forks source link

Artifacts when using WindowShine mod #119

Open AlexALX opened 6 years ago

AlexALX commented 6 years ago

Hello, i'm not sure how to properly report about issue, so i'm writing here.

When i install this mod with scatterer together i have artifacts in map view when there is trajectory prediction - game start flicker with ocean or atmosphere. If there is no prediction for atmosphere entering there is no artifacts.

Here is screenshots: https://imgur.com/a/pSq0W

I'm not sure what exactly wrong and in what addon is incompatibility, so writing to both addons.

PiezPiedPy commented 6 years ago

Hi. Are you using the latest version of Trajectories v.1.7.1 and what options did you have set in Trajectories. i.e. InFlight , Complete, BodyFixed etc.

AlexALX commented 6 years ago

Hello, yes i'm using latest (1.7.1) version of trajectories. As for options - it does not matter, if i change inflight/complete/bodyfixed issue still here, but if i disable trajectories then issue gone. So this is oblivious conflict between addons, but what wrong - i have no idea.

PiezPiedPy commented 6 years ago

Thanks for the info. I'll download scatterer and test in the near future and see if I get the same bug.

PiezPiedPy commented 6 years ago

@AlexALX OK, so I installed scatterer and could not reproduce the bug you encountered but I did notice a number of errors from scatterer. maybe you can pass on the information to them and see what they say.

[Scatterer] Error calling clouds2d.reassign() on planet: KerbinSystem.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary. at System.Collections.Generic.Dictionary2[System.String,System.Collections.Generic.List1[System.Object]].get_Item (System.String key) [0x00000] in <filename unknown>:0 at scatterer.SkyNode.UpdateNode () [0x00000] in <filename unknown>:0

Also a number of NRE's

NullReferenceException: Object reference not set to an instance of an object at scatterer.RefractionCamera.OnPreCull () [0x00000] in <filename unknown>:0 (Filename: Line: -1) skynode added refraction cam

Could you try this development build and let me know if the bug remains, Thanks.

Trajectories-v1.7.2-dev.zip

AlexALX commented 6 years ago

Ok i did test it with latest trajectories and issue still was here. After some manipulations with my GameData folder i detected when exactly this bug start appear - if use ksp with scatterer + trajectories + WindowShine. If i remove WindowShine then everything is ok for both mods. So incompatibility is with WindowShine and not scatterer itself. Even without scatterer i still can see some weird lines when use trajectories with WindowShine or via versa... So please check it with WindowShine. I'm going to report about issue to this mod too.

PiezPiedPy commented 6 years ago

No probs, I'll try with WindowShine in the next few days and see if I can trace the problem

LGhassen commented 6 years ago

I tried this without scatterer and there seems to be flashing artifacts in map view when using both trajectories and textureReplacerReplaced (used by windowshine).

These artifacts to me resemble IVA view or some kind of glitched out local camera from inside the ship.

Temporarily when the effect flashes you can't see the trajectory prediction.

https://i.imgur.com/LLPLYxK.jpg

When it doesn't flash you can see the trajectory

https://imgur.com/a/mLfnO

My guess would be that trajectories re-enables the local cameras in map view for some reason when used with textureReplacerReplaced, no issues in the logs or anything.

PiezPiedPy commented 6 years ago

@LGhassen Thanks for the Tip, hopefully its something simple.

ghost commented 6 years ago

I'm also experiencing this with Trajectories v2.0.0, WindowShine v16, TextureReplacerReplaced v0.5.4 and scatterer v0.0324 (all four installed via CKAN, not sure if that's important) on KSP 1.3.1 for Windows (64-bit). As described in the history of this issue, the behaviour occurs while in map view and having Trajectories enabled. Changing any settings but the "Display trajectory" option does not result in any changes.

Is this still being worked on?

The following may be unrelated to this issue, but while I'm not in the map view, another flickering artifact is displayed when reaching high orbit around Kerbin which does not disappear even when the "Display trajectory" option is off. The only way to get rid of the flickering shadow is to reload the scene, either by switching to a different vessel or quicksave followed by quickload. Due to that, I'm not sure if this is connected to Trajectories at this point in time. I will do some further testing without Trajectories installed to see if the issue persists.