search

neuoy / OneWireArduinoSlave

An arduino library to communicate using the Dallas one-wire protocol, where the Arduino takes the role of a slave. Entirely implemented using interrupts, you can perform other tasks while communication is handled in background.
58 stars 19 forks source link

Move to a "standard" library #17

Closed destroyedlolo closed 6 years ago

destroyedlolo commented 6 years ago

Hello,

With these changes, OneWireArduinoSlave can be used as a standard library and comply with IDE Arduino standards (I hope :) )

Bye

neuoy commented 6 years ago

Hi,

Thanks for this contribution :)

I have not merged because the layout I've put in place is a bit different ; I just wanted to separate library files intended for distribution (in library/OneWireSlave) from other files (at the root of the repository). But I've included your changes (and therefor ntruchsess' ones as well) ; I hope this won't make it too complicated for you to merge, if you want to.

neuoy commented 6 years ago

Well, I've changed my mind, and used the layout from ntruchsess (merged his library branch). I'm still not merging your branch because it has a yet different layout (no utility folder) and includes other unrelated changes. I think you should have less trouble merging on your side though, if you want to. Thanks again for pointing out the correct Arduino IDE layout, at least now it should be compatible with everyone needs (Arduino IDE users, and those like me who just compile the code as a regular C/C++ codebase).