add TriggerSender - Githubissues

neuralabc / spft-java

Sequential Pinch Force Task (SPFT) implemented in Java

1 stars 2 forks source link

add TriggerSender #5

Closed steelec closed 1 year ago

steelec commented 2 years ago

Create TriggerSender class in hardware and pull all the way through to the Trial level as per discussion w/ @theHilikus skeleton outlined in df91dc31ad12553760eff484f6dfabb954cda9b9

steelec commented 2 years ago

implemented in https://github.com/neuralabc/spft-java/tree/enh-trigger, awaiting final device testing for merge

steelec commented 2 years ago

@ajhelum to confirm:

[x] inclusion of / enabling of trigger does not affect data recording
[x] inclusion of / enabling of trigger does not affect temporal precision of program (including smoothness of display to monitor)
[x] inclusion of / enabling of trigger does not affect CPU usage (which could result in any of the above)
[x] arduino trigger device does not affect EMG
[x] arduino trigger device does not affect EEG

steelec commented 2 years ago

implemented in https://github.com/neuralabc/spft-java/tree/enh-trigger, awaiting final device testing for merge

note other changes in this branch will include altering the meaning of presentation frequency to refer to # milliseconds for displaying each element of a sequence (from Hz, which was less precise) and likely some intermediate implementation of dynamic time warping ( #6 )

ajhelum commented 1 year ago

Arduino trigger device is receiving trigger signals from SPFT for all testing files (yaml) smoothly, in one java session. (no need to open fresh session for running separate files) Tested with 1.4 jar (recent as of May 03 2023). No trigger delays observed.

steelec commented 1 year ago

thank you for the testing, I think this is ready for merge into main

steelec commented 1 year ago

included here: #8

steelec commented 1 year ago

now #8 merged into main