Open woctezuma opened 11 months ago
Can confirm, fix works :)
Again getting the same error "RetinaFace.detect() got an unexpected keyword argument 'threshold'". Can you share your .ipynb file?
!git clone https://github.com/woctezuma/SimSwap.git I have used insightface==0.7.3
!git clone https://github.com/woctezuma/SimSwap.git I have used insightface==0.7.3
You should use the branch which incorporates the fix.
!git clone https://github.com/woctezuma/SimSwap.git --branch upgrade-insightface --single-branch
Otherwise you get the main branch, which is an exact copy of the official SimSwap
.
Ok thank you, It works like a charm. It is 9 commits behind, will you update it?
Ok thank you, It works like a charm. It is 9 commits behind, will you update it?
I can do that, but there is no much point: only the README and the notebook were modified in the 9 commits, so no Python code.
Edit: Done this time, but the point of this branch is that the pull request could be merged in the official repository, not to maintain it whenever there is a new update in the official repository. 😛
ok Thanks by the way.
In the latest insightface version, delete line 65 of insightface_func/face_detect_crop_multi.py
:
bboxes, kpss = self.det_model.detect(img,
threshold=self.det_thresh, <---remove this LINE
max_num=max_num,
metric='default')
TO
bboxes, kpss = self.det_model.detect(img,
max_num=max_num,
metric='default')
face_detect_crop_single.py
is same.
Yes, that is partially what I did:
In the latest insightface version, delete line 65 of
insightface_func/face_detect_crop_multi.py
:
If you only do that, then you cannot specify the detection threshold. For instance, the default value (0.5) is used instead of 0.6.
NB: antelope.zip
contains a file hinting at SCRFD for detection:
glintr100.onnx
recognitionscrfd_10g_bnkps.onnx
detectionbased on the outputs found in Colab:
find model: ./insightface_func/models/antelope/glintr100.onnx recognition
find model: ./insightface_func/models/antelope/scrfd_10g_bnkps.onnx detection
So the detection model is SCRFD.
The following issue arises with
insightface==0.6.2
or below, including the recommended version (0.2.1).See:
445
This issue is fixed by upgrading to
insightface==0.7
or above, but the following issue arises.This pull request fixes this second issue, which allows to use the latest version of
insightface
(0.7.3).Fix:
139
407