search

neuralinkcorp / tsui

An (experimental) elegant TUI for configuring Tailscale.
https://neuralink.com/tsui
MIT License
246 stars 3 forks source link

Add network peers menu #15

Closed leon332157 closed 2 weeks ago

leon332157 commented 1 month ago

Initially ported Edward's code to the more recent version.

Currently struggling to figure out how to expand the column width of the menu items as I would like to fit OS as well as ownership information, similar to tailscale status command. Would love some advice.

kognise commented 2 weeks ago

I pushed some updates and improvements to how I would like the UI to look.

However, there's a bug in the menu rendering code and it needs to be rewritten — it doesn't properly handle multi-line menu items and if many are on screen the top of the menu gets cut off. It needs some sort of progressive layout engine. I don't have the time right now but you could take a stab if you wanted!

kognise commented 2 weeks ago

jk i implemented it, push incoming

leon332157 commented 2 weeks ago

For situations where the clipboard can not be accessed, over ssh for example, how do you plan to display the peer ip address?

kognise commented 1 week ago

After a little more thinking I definitely agree that IP would be more helpful than host OS here. For now, I'll make an update to show the IP instead.

Longer term we want an info window that shows multiple properties of the host. I wanted to push out some sort of working peer menu before implementing this but I will kick it off soon.

On Thu, Sep 5, 2024, 08:03 Leon Ge @.***> wrote:

For situations where the clipboard can not be accessed, over ssh for example, how do you plan to display the peer ip address?

— Reply to this email directly, view it on GitHub https://github.com/neuralinkcorp/tsui/pull/15#issuecomment-2331955485, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKEVYGNKTEPNACKKTGVU5ETZVBXF7AVCNFSM6AAAAABMZFHALCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZRHE2TKNBYGU . You are receiving this because you modified the open/close state.Message ID: @.***>