Closed dsikka closed 9 months ago
is this a breaking change if we were using --model_path
first? this seems fairly important for all server flows and we should hopefully be able to deprecate rather than removing
@mgoin yes. If we make model_path
an argument to support the UX docs, we can't use it as an option as well ---model_path
We could add a separate model path entry point but click can't support both AFAIK
@mgoin yes. If we make
model_path
an argument to support the UX docs, we can't use it as an option as well---model_path
We could add a separate model path entry point but click can't support both AFAIK
@dsikka per @markurtz lets add a model_path kwarg back in (can rename the positional arg to something else) and allow it to override the positional if given. (Would need to make the positional arg optional in this case I guess)
Summary:
click
set-up, to get the use case described in this ticket (shown below): https://app.asana.com/0/1206109050183159/1206524727025314/fPR Update
This PR allows us to get the following cli command:
We can run the following commands with the current set-up:
Caveats (@bfineran):
Shoutout to @rahul-tuli for his click knowledge and help