Closed dbarbuzzi closed 4 months ago
Seems like there was a single failure in 3.11:
Should the default values be True too?
VLLM_NO_USAGE_STATS: bool = False VLLM_DO_NOT_TRACK: bool = False
Should the default values be True too?
That section is purely for type-checking (as in, it is never actually executed because it’s protected by the if TYPE_CHECKING
clause), however, I think this is a good change for clarity, so I pushed it.
This PR force-disables upstream tracking by forcing
VLLM_DO_NOT_TRACK
andVLLM_NO_USAGE_STATS
to beTrue
(disable data collection) rather than inspecting the environment variable.An alternative approach could be to update the definition of
is_usage_stats_enabled
(invllm/usage/usage_lib.py:29
) to always returnFalse
and set theglobal _USAGE_STATS_ENABLED
to beFalse
.