search

neuroailab / tfutils

Utilities for working with tensorflow
MIT License
25 stars 8 forks source link

Load #22

Closed yamins81 closed 7 years ago

yamins81 commented 7 years ago

Hi @qbilius here is a PR for the code that I wrote last week. There are a couple of issues I'd like to discuss with you about it.

Here are some questions -- these are mostly notes for us when we talk: 1) I still need to write a test for the feature extraction API. 2) do we want to load from __RECENT for validation, or just allow loading from the "real" storage? 3) do we want to force load_params to be used instead of save params? 4) am I handling scoping correctly? I have some questions/comments here about exactly what we want to do.

yamins81 commented 7 years ago

We agreed to group the saving db params as "save_params" in analogy to load_params

yamins81 commented 7 years ago

ok @qbilius I've added an extraction test and done the save_params items stuff we agreed to. Can you have a look at the PR now for review?

qbilius commented 7 years ago

Great! I'll get to it on Friday. Tomorrow is nearly the whole day of meetings for me.