neuroailab / tfutils

Utilities for working with tensorflow
MIT License
25 stars 8 forks source link

Split up Saver and Loader?? #39

Closed qbilius closed 6 years ago

qbilius commented 7 years ago

Proposed split: DBInterface as a base class that sets up host, collection etc and has a get_recordmethod, with Saver and Loader inheriting from this class. See base.py in clean_interface branch for an example.

Benefits:

yamins81 commented 7 years ago

I'm fairly happy with the code as it stands. I don't see a good reason to have two classes (loader, saver) where we can have one that has all the methods together. Anyhow, this seems like a mostly aesthetic issue to me, but there are a whole set of real functionality issues (like #29, #33) that are pressing and that I feel we should be focusing on instead. I'm going to close this issue for now ... maybe we can reopen it later once those other functionality issues are dealt with.

yamins81 commented 7 years ago

Alright, I've reopened this issue, but changed the title to reflect the fact that I'm not really convinced this is the right approach. Let's keep this on the back burner until a bunch of enhancements/bugfixes are done and then consider it again then.