Closed r03ert0 closed 5 years ago
I would like to work on this :)
nice!
On Tuesday, October 17, 2017, Tulika notifications@github.com wrote:
I would like to work on this :)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenNeuroLab/BrainBox/issues/156#issuecomment-337271372, or mute the thread https://github.com/notifications/unsubscribe-auth/ACNCTG--xqDN5_85KBoapA389n0t4o9Pks5stMzWgaJpZM4P8RT6 .
can you review my PR please? i have to make more changes i would like to know if i am doing it right. Also i cant figure out how to convert this one : L296 thankyou.
Is this a feature request or a bug report?
This is an enhancement request
What is the current behaviour?
Currently brainbox uses jQuery promises, which look like this:
What is the expected or desired behavior?
Use standard ES promises, which look like:
Other than that, brainbox uses the $.when promises, which should be replaced with Promise.all([]).