Closed Nnubes256 closed 6 years ago
Amaaaazing!! π \ΓΆ// Thank you very much for your contributions! The eyedropper tool works very nicely when I click a region that is actually painted. But if I click outside of the mask, I get an error form atlasMaker-interaction.js:685
Uncaught TypeError: Cannot read property 'name' of undefined
at Object.down (atlasMaker-interaction.js:685)
at HTMLCanvasElement.mousedown (atlasMaker-interaction.js:466)
Could you add a test if the mouse click hits a region of the mask, then display the info, if not return? That would be fantastic! π I tested like this:
http://brainbox.pasteur.fr/mri?url=https://s3.amazonaws.com/fcp-indi/data/Projects/ABIDE_Initiative/Outputs/freesurfer/5.1/CMU_a_0050656/mri/T1.mgz
with the download button in the tool bar, http://localhost:3000/mri?url=https://s3.amazonaws.com/fcp-indi/data/Projects/ABIDE_Initiative/Outputs/freesurfer/5.1/CMU_a_0050656/mri/T1.mgz
aseg.nii.gz
mask to this brain with the upload button.Looking forward to merging your pull request!! Thank you very much again for your work!! π
@Nnubes256 : I merged your pr to avoid future merge conflicts and it displays the name and does not break the app\ΓΆ/ so, many thanks for your work again! But I would deeply appreciate if you open a new one with the fix for the error described in my previous comment. mille merci! π
Sure thing!
Fixes #159. Additionally, I fixed the formatting of the only changed function in order to keep consistency.