neuroanatomy / BrainBox

BrainBox is a web application that lets you annotate and segment 3D brain imaging data in real time, collaboratively.
https://brainbox.pasteur.fr
Other
96 stars 46 forks source link

Update top-left information when clicking with the eye-dropper tool #162

Closed Nnubes256 closed 6 years ago

Nnubes256 commented 6 years ago

Fixes #159. Additionally, I fixed the formatting of the only changed function in order to keep consistency.

katjaq commented 6 years ago

Amaaaazing!! πŸ˜ƒ \ΓΆ// Thank you very much for your contributions! The eyedropper tool works very nicely when I click a region that is actually painted. But if I click outside of the mask, I get an error form atlasMaker-interaction.js:685

Uncaught TypeError: Cannot read property 'name' of undefined
    at Object.down (atlasMaker-interaction.js:685)
    at HTMLCanvasElement.mousedown (atlasMaker-interaction.js:466)

Could you add a test if the mouse click hits a region of the mask, then display the info, if not return? That would be fantastic! πŸ™‚ I tested like this:

Looking forward to merging your pull request!! Thank you very much again for your work!! πŸ˜ƒ

katjaq commented 6 years ago

@Nnubes256 : I merged your pr to avoid future merge conflicts and it displays the name and does not break the app\ΓΆ/ so, many thanks for your work again! But I would deeply appreciate if you open a new one with the fix for the error described in my previous comment. mille merci! πŸ˜ƒ

Nnubes256 commented 6 years ago

Sure thing!