[WIP] chore: replace jquery promises with native ones

neuroanatomy / BrainBox

BrainBox is a web application that lets you annotate and segment 3D brain imaging data in real time, collaboratively.

https://brainbox.pasteur.fr

Other

96 stars 46 forks source link

[WIP] chore: replace jquery promises with native ones #166

Closed koddsson closed 6 years ago

koddsson commented 6 years ago

I tried my best replacing all the $.Deferred instances with new Promise(...) instances but I think there's some things that we need to change in this PR to land it.

[ ] Fix the indentation. Somehow all the indentation is all messed up here. I think it's some issue with my IDE. What should the indentation be?
[ ] Verify functionality where promises were refactored. I couldn't get the app running on my local machine to make sure everything works after this change.

katjaq commented 6 years ago

Thank you so much for your work! I see – the indentation looks a little wild :) but it is just that your new code is a little too much indented. We use four spaces for every indent. Would it be possible for you to fix the indentation?

Regarding testing the functionalities – would you be interested in getting the app running on your system? We will be happy to help!! (What is your operating system? Does npm install throw errors? Or what are the errors you have encountered?) Otherwise, no problem I could get your pr and test it here and see what it says...

Many thanks again for your contributions! \ö/ 👍

katjaq commented 6 years ago

I checked everything! All functionalities work as expected! \ö// great job! :D I will merge your PR and go fix the indentation :)

Thank you very much for your contribution to BrainBox!! 😃 👍

koddsson commented 6 years ago

@katjaq ❤️ Sorry for not fixing the indentation and such sooner 🙇