search

neuroanatomy / BrainBox

BrainBox is a web application that lets you annotate and segment 3D brain imaging data in real time, collaboratively.
https://brainbox.pasteur.fr
Other
96 stars 46 forks source link

Apply `xo --fix` on a few files #169

Closed daniloisr closed 6 years ago

daniloisr commented 6 years ago

This is the first step to fix linter errors.

I'll be tunning XO config according to the project style.

Issue related https://github.com/OpenNeuroLab/BrainBox/issues/168

daniloisr commented 6 years ago

These changes broke the server 😭 I'm fixing it right now ✔️ Fixed

katjaq commented 6 years ago

amaaazing!! thank you so much!! oh my! this number was soooo shocking :D

merged your pr! <3 thaaaaanks!

r03ert0 commented 6 years ago

xo --fix breaks brainbox in my machine (and in the server) : ( The server launches, but as soon as you try to load a brain, it breaks. I had to roll back to an older version, and I'm linting little by little now. In particular, I'm using {"space": 4} to be coherent with our other projects (github.com/r03ert0/microdraw)

daniloisr commented 6 years ago

@r03ert0 you are right, xo --fix breaks at no-buffer-constructor rule, where even turning it off in the package.json it still fixed during --fix. I think that this is a bug with XO.

After running --fix I had to revert the breaking changes with the code from this commit: https://github.com/OpenNeuroLab/BrainBox/pull/169/commits/a7ae627ff2fb4397fd3601aad5199b1f6dfcafdf