neuroanatomy / BrainBox

BrainBox is a web application that lets you annotate and segment 3D brain imaging data in real time, collaboratively.
https://brainbox.pasteur.fr
Other
96 stars 46 forks source link

Cleanup and Enhancement: Todo tasks completed, code cleaned up and nodemon added. #275

Closed adityaofficial10 closed 3 years ago

adityaofficial10 commented 3 years ago

Fixes #274 What does this PR do?

@katjaq @r03ert0 Kindly review the changes and add this task as completed in our project. Best Regards..

r03ert0 commented 3 years ago

thank you for this @adityaofficial10 ! changes to the frontend require npm run build. nodemon will just lunch the server again but will not rebuild, no? I think there's a way of making webpack rebuild on the fly, which would be a better alternative? Also, when running the tests, there are some files written to the screenshots folder. This may hint nodemon to rerun the server? Finally, we use visual studio code for development, and it frequently checks github for updates, which also writes a local file. This may also trigger a nodemon restart?

adityaofficial10 commented 3 years ago

Hey @r03ert0 @katjaq ! I suggest using watch for keeping track of the frontend files and whenever a change is made there, we can run the webpack build and when that finishes, nodemon can restart the server. I've figured out a way to ensure nodemon restarts after the webpack build is finished. This will make the development easier for the developer as it saves the time to manually close and restart everything. Does this sound good? Best Regards...

r03ert0 commented 3 years ago

let's try it! \o/

adityaofficial10 commented 3 years ago

@r03ert0 Thanks a lot. I'd quickly send a patch for review. Best Regards..