update User page - Githubissues

neuroanatomy / BrainBox

BrainBox is a web application that lets you annotate and segment 3D brain imaging data in real time, collaboratively.

https://brainbox.pasteur.fr

Other

96 stars 46 forks source link

update User page #296

Closed katjaq closed 3 years ago

katjaq commented 3 years ago

all tests passed, also I tried to test all functionalities

ntraut commented 3 years ago

hi,

there are some eslint errors in view/brainbox/src/pages/user-page.js but they don't appear because .eslintignore is badly configured (fixed in PR #287)
if we remove the two other tabs, the project should automatically appear on the user page without the need to click on projects
if there is a security issue, then it is more on the api than in this page, since this script only runs client side.

katjaq commented 3 years ago

hi @ntraut

Thank you very much for your feedback.

the files should all correspond to our linting style now
for me the project does appear automatically. Could you see if it works on your end now?
would be happy to tackle api separately Thank you very much for having another look ✨

katjaq commented 3 years ago

yeyy, Thank you for testing and your latest feedback @ntraut ! ✨ I am happy everything works on your end as well. \\ö// Will merge as discussed on mattermost :) Thanks!