neuroanatomy / BrainBox

BrainBox is a web application that lets you annotate and segment 3D brain imaging data in real time, collaboratively.
https://brainbox.pasteur.fr
Other
96 stars 46 forks source link

Add permissions integration tests #310

Closed dhovart closed 2 years ago

dhovart commented 2 years ago

I've added some integration tests to help with the refactoring and make sure I'm not pushing regressions. I've corrected some cases were users could add annotations or collaborators wihthout having the right to.

It would be great if you could review the different cases I've defined and tell me if they're ok.

dhovart commented 2 years ago

Tests should not fail anymore after https://github.com/neuroanatomy/NeuroWebLab/pull/4 is merged

katjaq commented 2 years ago

https://github.com/neuroanatomy/NeuroWebLab/pull/4 has been merged now

codecov-commenter commented 2 years ago

Codecov Report

Merging #310 (e5de228) into master (f836e35) will increase coverage by 2.39%. The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   58.52%   60.92%   +2.39%     
==========================================
  Files          17       17              
  Lines        2522     2577      +55     
==========================================
+ Hits         1476     1570      +94     
+ Misses       1046     1007      -39     
Flag Coverage Ξ”
integration 52.81% <81.48%> (+5.98%) :arrow_up:
unittests 42.41% <56.79%> (+0.38%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Ξ”
controller/project/project.controller.js 85.50% <82.75%> (+14.77%) :arrow_up:
controller/checkAccess/checkAccess.js 47.47% <90.00%> (+3.90%) :arrow_up:
controller/dataSlices/dataSlices.js 81.20% <100.00%> (+1.47%) :arrow_up:
controller/atlasmakerServer/atlasmakerServer.js 44.29% <0.00%> (-0.11%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update f836e35...e5de228. Read the comment docs.

katjaq commented 2 years ago

Awesome! πŸš€ πŸš€ πŸš€