improve token testing - Githubissues

neuroanatomy / BrainBox

BrainBox is a web application that lets you annotate and segment 3D brain imaging data in real time, collaboratively.

https://brainbox.pasteur.fr

Other

96 stars 46 forks source link

improve token testing #333

Closed ntraut closed 2 years ago

ntraut commented 2 years ago

test permissions with both tokens and session cookies separately
remove unnecessary token field checking in the request as req.user.username is also set with token
fix token expiration check in upload controller
fix anyone user removed after performing project controller unit tests
fix bug when testing for non existing project in project controller unit tests

ntraut commented 2 years ago

thank you for the merge! concerning the codeql alert, i wonder if it's not a false positive because the file in question is managed by the multer middleware, but it's hard to test because i don't see anywhere where the upload controller is used, there are tests for it but only on the set up part...