feat: prompt user - unsaved changes & nav away

neuroanatomy / microdraw

Collaborative vectorial annotation tool for ultra high resolution data

https://microdraw.pasteur.fr

GNU General Public License v3.0

23 stars 8 forks source link

feat: prompt user - unsaved changes & nav away #46

Open xgui3783 opened 2 years ago

xgui3783 commented 2 years ago

[x] Run npm test successfully.
[x] Run npm run mochasuccessfully.
[x] test_screenshots generates the same test pictures in test as there were in test/reference and does not show any errors

(I don't think new screenshots are generated properly?)

[ ] I implemented tests for the new changes OR
[x] These changes do not require tests because _____
[x] These changes fix https://github.com/neuroanatomy/microdraw/issues/36

xgui3783 commented 2 years ago

Unfortunately, I can't seem to test this functionality properly. The bundled images seems to have Hash to be undefined.

I will have to take a better look when I get a chance.

katjaq commented 2 years ago

Thank you so much for implementing this alert! 🌟 Could you check if the Hash is really used somewhere? It is maybe implemented in the client but not in the server?