neuroanatomy / thresholdmann

A tool to apply a smoothly varying threshold to a nifti image
https://neuroanatomy.github.io/thresholdmann/index.html
ISC License
3 stars 2 forks source link

[joss][tests] Test run failure - `before` hook times out #18

Closed sneakers-the-rat closed 6 months ago

sneakers-the-rat commented 6 months ago

Part of: https://github.com/openjournals/joss-reviews/issues/6336

Thank you for your feedback.

Current behaviour

Trying to run tests:

npm install
npm run test

yields

> thresholdmann@1.0.0 test
> mocha --exit

  Test Thresholdmann
    1) "before all" hook in "Test Thresholdmann"

  0 passing (5s)
  1 failing

  1) Test Thresholdmann
       "before all" hook in "Test Thresholdmann":
     Error: Timeout of 5000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/jonny/git/forks/thresholdmann/test.mjs)
      at listOnTimeout (node:internal/timers:573:17)
      at process.processTimers (node:internal/timers:514:7)

I suspect this has something to do with my use of lulu to block most traffic to google, as chrome attempts to launch and requests network access. I allowed it temporarily but that created a new issue:

  1) Test Thresholdmann
       "before all" hook in "Test Thresholdmann":
     Error: net::ERR_CONNECTION_REFUSED at http://127.0.0.1:8080

Expected behaviour

Expected to run tests!

Version information (for bug reports)

Possible causes

katjaq commented 6 months ago

Thank you so much for reporting this and fixing it for us ❤️ 🌟 🚀

katjaq commented 6 months ago

Closing this as kindly fixed by @sneakers-the-rat <3