neuroanatomy / thresholdmann

A tool to apply a smoothly varying threshold to a nifti image
https://neuroanatomy.github.io/thresholdmann/index.html
ISC License
3 stars 2 forks source link

[joss][tests] Add test cases for listed functionality #20

Closed sneakers-the-rat closed 5 months ago

sneakers-the-rat commented 6 months ago

Part of: https://github.com/openjournals/joss-reviews/issues/6336

Ensure tests cover functionalities listed in /doc.html

I think most of this could be done by having a known-good mask for the demo input data at 2 or 3 configurations of points/thresholds. I think you may want to refactor into a tests directory to be able to group input/output data separately from the img directory, which seems to be the public img directory used on the site.

Authors lmk which of these are impossible/etc. i'm just recreating the list from /doc.html :)

katjaq commented 5 months ago

Thank you for your suggestions @sneakers-the-rat ! All the tests have now been implemented and merged in the PR mentioned above #29 . Thank you @ntraut !

We will let you check it out and look forward to your reply or approval :)

sneakers-the-rat commented 5 months ago

best test description of all time. shouldn't all code? <3 https://github.com/neuroanatomy/thresholdmann/blob/9861286089b7b0ec9b89b77a5b50971820613440/test.mjs#L38

sneakers-the-rat commented 5 months ago

Looks great! thanks for working on this. hopefully that helps with contribs and gives you one less thing to lose sleep over in the future of this tool :)