search

neuroanatomy / thresholdmann

A tool to apply a smoothly varying threshold to a nifti image
https://neuroanatomy.github.io/thresholdmann/index.html
ISC License
3 stars 2 forks source link

[joss] fix incomplete attribute selectors in keyboard shortcuts #27

Closed sneakers-the-rat closed 6 months ago

sneakers-the-rat commented 7 months ago

Part of: https://github.com/openjournals/joss-reviews/issues/6336

The keyboard shortcuts currently use incomplete attribute selectors, eg.

querySelector('[title="Select"')

These work, but they shouldn't since i think all levels of the CSS spec say browsers should ignore invalid selectors.

In any case, my linter is yelling at these being incomplete, so here's a function-neutral PR to make it be quiet.

katjaq commented 6 months ago

Thank you @sneakers-the-rat for pointing out and fixing <3 the issue! 🚀