neuroanatomy / thresholdmann

A tool to apply a smoothly varying threshold to a nifti image
https://neuroanatomy.github.io/thresholdmann/index.html
ISC License
3 stars 2 forks source link

[joss][ui] numeric input #38

Closed anibalsolon closed 4 months ago

anibalsolon commented 6 months ago

Part of: https://github.com/openjournals/joss-reviews/issues/6336

Currently, the threshold inputs are of type text. Given you are providing min and max, I assume it will always be a number. I'd suggest to change the field type to "number", so 1) the range is applied, and 2) no other values are provided (e.g. characters).

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number

image

katjaq commented 6 months ago

Thank you for the suggestion. We implemented this change of input type from text to number in commit #ffbda69