neurobagel / annotation_tool

https://annotate.neurobagel.org/
MIT License
3 stars 6 forks source link

Validate supplied .tsv and .json files #49

Open surchs opened 2 years ago

surchs commented 2 years ago

As a user, when I upload my participants.tsv (and data_dictionary.json) file to the annotator, I want to receive a visual confirmation that the uploaded files have passed some validation, so that I immediately know whether there are any problems with the files before I start spending time on annotations.

When users upload participant.tsv and optional .json data dictionaries with our tool, the file upload interface currently filters available files on the file system by the correct file ending. However, users can either change that or upload a file with the correct file ending but the wrong content (e.g. a .tsv file that is in fact a .csv, etc).

We could validate the supplied file content before we proceed to the categorization page in order to avoid strange breaks when we try to parse the files and they turn out to be something other than what we expect.

github-actions[bot] commented 1 year ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

surchs commented 1 year ago

I think this could be good to include in round 2 after the refactor.

github-actions[bot] commented 1 year ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

jarmoza commented 1 year ago

@surchs Still thinking of this for refactor round 2? I'm thinking this might spill over into the next cycle depending on the rest of the phase 2 refactor tasks go from here until end of month.

github-actions[bot] commented 1 year ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days. We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

surchs commented 11 months ago

When #597 is done, we could apply the same logic to validate the input data as well.

github-actions[bot] commented 8 months ago

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days. We have applied the _flag:stale label to indicate that this issue should be reviewed again. When you review, please reread the spec and then apply one of these three options: