Open surchs opened 11 months ago
We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale
label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:
flag:schedule
label to suggest moving this issue into the backlog nowsomeday
label to show that this won't be prioritized. The stalebot will ignore issues with this
label in the future. Use sparingly!
This is a bit of a 180 on what we had discussed previously - giving component direct store access instead of pushing props around. I think the reasoning behind that decision was good: make it super clear who has responsibility for the global state.
However, this came with two downsides:
I suggest we keep what's good about the current solution, but slowly remove / refactor what's bad about it.
The good (what we keep):
The bad (what we want to change):
Instead we should:
Given our very strong test suite, we should be able to approach this refactor step by step, e.g. by changing pages and components we are already working on for some other reason.