[REF] Make session count names clearer in query response - Githubissues

neurobagel / api

https://api.neurobagel.org/

MIT License

4 stars 3 forks source link

[REF] Make session count names clearer in query response #282

Closed alyssadai closed 8 months ago

alyssadai commented 8 months ago

Closes #271

Changes proposed in this pull request:

Response model for a single matching session response updated
Query template updated
Default SPARQL query regenerated

Note:

the query parameters themselves have not been renamed (b/c min_num_{phenotypic,imaging}_sessions still makes more sense in a query)
we currently (still) do not have a field in a single session query response that indicates the total (not matching) num. of sessions available for the subject. however, this can be deduced from the number of session objects present for a subject in the full response

Checklist

[x] PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) _(see https://neurobagel.org/contributing/pull_requests for more info)_
[x] PR has a label for the release changelog or skip-release (to be applied by maintainers only)
[x] PR links to GitHub issue with mention Closes #XXXX
[x] Tests pass
[x] Checks pass

For new features:

[ ] Tests have been added

For bug fixes:

[ ] There is at least one test that would fail under the original bug conditions.

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 8083459842

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 99.785%

Totals
Change from base Build 7999458202:	0.0%
Covered Lines:	929
Relevant Lines:	931

💛 - Coveralls

surchs commented 6 months ago

:rocket: PR was released in v0.2.0 :rocket: