neurobagel / api

https://api.neurobagel.org/
MIT License
4 stars 3 forks source link

Queries for `is_control=False` no longer work with restriction against unbound variables #332

Closed alyssadai closed 5 days ago

alyssadai commented 2 months ago

This is really only a problem for the interactive docs, where setting is_control to False is an option.

See also this note:

https://github.com/neurobagel/api/blob/0bea618aec64dda22df43378236bbf2a30793704/app/api/utility.py#L191-L194

hasSubjectGroup can never be != IS_CONTROL_TERM because the only possible subject group at the moment is healthy control. Otherwise, a subject would not have this property in the first place. So allowing users to query for a value of False will always return no results, violating the user expectations.

TODO:

neurobagel-bot[bot] commented 5 days ago

:rocket: Issue was released in v0.4.0 :rocket: